Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(api/nonfungibles): fork pallet nfts #342

Closed
wants to merge 17 commits into from
Closed

chore(api/nonfungibles): fork pallet nfts #342

wants to merge 17 commits into from

Conversation

chungquantin
Copy link
Collaborator

@chungquantin chungquantin commented Oct 14, 2024 •
edited
Loading

Description

Fork of pallet-nfts v1.15.0 for the implementation of pallet-api/non-fungibles: #339.

Only changes I made is the Cargo.toml to update it consistent with other pallets.

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 59.55118% with 1478 lines in your changes missing coverage. Please review.

Project coverage is 68.38%. Comparing base (52fb7f0) to head (92ccee9).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pallets/nfts/src/weights.rs 1.86% 736 Missing ⚠️
pallets/nfts/src/impl_nonfungibles.rs 22.06% 266 Missing and 6 partials ⚠️
pallets/nfts/src/lib.rs 71.82% 53 Missing and 78 partials ⚠️
pallets/nfts/src/migration.rs 0.00% 53 Missing ⚠️
pallets/nfts/src/types.rs 67.11% 49 Missing ⚠️
pallets/nfts/src/features/attributes.rs 86.36% 19 Missing and 23 partials ⚠️
pallets/nfts/src/benchmarking.rs 85.79% 11 Missing and 14 partials ⚠️
pallets/nfts/src/features/transfer.rs 83.84% 9 Missing and 12 partials ⚠️
pallets/nfts/src/features/create_delete_item.rs 89.20% 5 Missing and 14 partials ⚠️
runtime/testnet/src/config/api/versioning.rs 90.60% 17 Missing ⚠️
... and 11 more 
@@             Coverage Diff             @@
##             main     #342       +/-   ##
===========================================
+ Coverage   51.60%   68.38%   +16.77%     
===========================================
  Files          48       70       +22     
  Lines        4910    11846     +6936     
  Branches     4910    11846     +6936     
===========================================
+ Hits         2534     8101     +5567     
- Misses       2327     3486     +1159     
- Partials       49      259      +210
Files with missing lines Coverage Δ
pallets/nfts/src/mock.rs 100.00% <100.00%> (ø)
pallets/nfts/src/tests.rs 99.88% <ø> (ø)
runtime/devnet/src/lib.rs 5.53% <ø> (ø)
runtime/testnet/src/config/contracts.rs 83.33% <ø> (ø)
runtime/testnet/src/lib.rs 6.44% <ø> (+1.07%) ⬆️
pallets/nfts/src/features/roles.rs 96.15% <96.15%> (ø)
pallets/nfts/src/features/approvals.rs 93.25% <93.25%> (ø)
pallets/nfts/src/common_functions.rs 80.00% <80.00%> (ø)
pallets/nfts/src/features/buy_sell.rs 90.69% <90.69%> (ø)
pallets/nfts/src/features/lock.rs 90.12% <90.12%> (ø)
... and 16 more

Daanvdplas and others added 4 commits October 21, 2024 09:41
@Daanvdplas
chore: timestamp settings for tests (#347)
f213164
@al3mart @Daanvdplas
chore(testnet-runtime): v0.4.2 (#369)
f801a70 
Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
@al3mart @Daanvdplas @peterwht
docs: pop-api v0 fungibles READMEs (#365)
d642b42 
Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
Co-authored-by: Peter White <petras9789@gmail.com>
@chungquantin @Daanvdplas
@evilrobot-01 @peterwht @al3mart @dependabot @AlexD10S
feat: psp22 trait contract example with drink tests (#300)
3cdb9b5 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: R0GUE <daanvdplas@live.nl>
Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
Co-authored-by: Frank Bell <frank@r0gue.io>
Co-authored-by: Frank Bell <60948618+evilrobot-01@users.noreply.github.com>
Co-authored-by: Peter White <petras9789@gmail.com>
Co-authored-by: Alejandro Martinez Andres <11448715+al3mart@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex Bean <alexfraga10@gmail.com>
@chungquantin chungquantin marked this pull request as ready for review November 12, 2024 09:31
@chungquantin chungquantin changed the title chore: pallet nfts chore(api/nonfungibles): fork pallet nfts Nov 12, 2024
@chungquantin chungquantin self-assigned this Nov 12, 2024
Daanvdplas and others added 9 commits November 12, 2024 18:24
@Daanvdplas @chungquantin
chore: timestamp settings for tests (#347)
6f408f5
@al3mart @Daanvdplas @chungquantin
chore(testnet-runtime): v0.4.2 (#369)
47fdb2c 
Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
@al3mart @Daanvdplas
@peterwht @chungquantin
docs: pop-api v0 fungibles READMEs (#365)
39d3320 
Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
Co-authored-by: Peter White <petras9789@gmail.com>
@chungquantin @Daanvdplas
@evilrobot-01 @peterwht @al3mart @dependabot @AlexD10S
feat: psp22 trait contract example with drink tests (#300)
1b76e26 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: R0GUE <daanvdplas@live.nl>
Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
Co-authored-by: Frank Bell <frank@r0gue.io>
Co-authored-by: Frank Bell <60948618+evilrobot-01@users.noreply.github.com>
Co-authored-by: Peter White <petras9789@gmail.com>
Co-authored-by: Alejandro Martinez Andres <11448715+al3mart@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex Bean <alexfraga10@gmail.com>
@chungquantin
chore: forked pallet nfts
ecec34b
@chungquantin
fix: formatting
cb0a6c9
@chungquantin
fix: formatting
71670af
@chungquantin
chore: update Cargo.toml
5b49a74
@chungquantin
Merge remote-tracking branch 'refs/remotes/origin/chungquantin/chore-…
92ccee9 
…pallet_nfts' into chungquantin/chore-pallet_nfts
@chungquantin chungquantin deleted the chungquantin/chore-pallet_nfts branch November 13, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chungquantin chungquantin

Labels
ready-for-final-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chungquantin @codecov-commenter @Daanvdplas @al3mart